Home
EXECUTED
Ended Apr 21 at 6:39 PM UTC

[EP 6.40] [Executable] Update DNSSEC Algorithm 7

By
Votes
1.35Mfor
0against
134.62%Quorum
Skip to Votes

Abstract

This proposal updates DNSSECImpl's algorithm 7 (RSASHA1-NSEC3-SHA1) to point to the same patched RSASHA1Algorithm contract that already serves algorithm 5. This was inadvertently omitted from the previous proposal which patched algorithms 5, 8, and 13.

Motivation

The ENS deploy script (10_deploy_oracle.ts) maps both algorithm 5 and algorithm 7 to the same RSASHA1Algorithm contract, as they share identical RSA+SHA1 verification logic. When the previous proposal was executed, setAlgorithm was called for algorithms 5, 8, and 13, but algorithm 7 was missed.

Algorithm 7 currently still points to the pre-patch contract at 0x6ca8624Bc207F043D140125486De0f7E624e37A1, which lacks PKCS#1 v1.5 padding validation.

Current impact is negligible — no TLD in the ENS ecosystem currently uses algorithm 7. The TLDs affected by the original vulnerability (.cc, .name) used algorithm 8, which was patched in the previous proposal. However, this should be corrected to match the intended configuration and to close the gap left by the previous deployment.

Specification

A single setAlgorithm call on DNSSECImpl (0x0fc3152971714E5ed7723FAFa650F86A4BaF30C5):

Algorithm IDContractAddress
7 (RSASHA1-NSEC3-SHA1)RSASHA1Algorithm (patched)0x58E0383E21f25DaB957F6664240445A514E9f5e8

No new contract deployment is needed — this reuses the same patched contract already serving algorithm 5.

Transaction

#ContractFunctionParameters
1DNSSECImplsetAlgorithm(uint8,address)7, 0x58E0383E21f25DaB957F6664240445A514E9f5e8

Calldata:

cast calldata "setAlgorithm(uint8,address)" 7 0x58E0383E21f25DaB957F6664240445A514E9f5e8

Verification

After execution, confirm:

cast call 0x0fc3152971714E5ed7723FAFa650F86A4BaF30C5 "algorithms(uint8)(address)" 7
# Expected: 0x58E0383E21f25DaB957F6664240445A514E9f5e8
Votes
1.35Mfor
0against
134.62%Quorum
0x5bfc...83900x5bfc...8390voted for
253.99K
0xb8c2...67d50xb8c2...67d5voted for
149.34K
0x1d54...63590x1d54...6359voted for
114.93K
0x5346...42cf0x5346...42cfvoted for
111.16K
0x9831...67440x9831...6744voted for
98.71K
0xd5d1...cf2c0xd5d1...cf2cvoted for
92.54K
0xa786...77c60xa786...77c6voted for
85.36K
0xb352...8b1b0xb352...8b1bvoted for
60K
0x54be...7ab60x54be...7ab6voted for
57.89K
0x8393...07800x8393...0780voted for
51.86K
0x2d7d...b05e0x2d7d...b05evoted for
46.35K
0xac50...c0390xac50...c039voted for
41.3K
0xa8b4...28e80xa8b4...28e8voted for
40.51K
0x7f77...1caa0x7f77...1caavoted for
33.21K
0x8b1f...feff0x8b1f...feffvoted for
32.4K
0x7ae9...0c0b0x7ae9...0c0bvoted for
10.37K
0x1f3d...05910x1f3d...0591voted for
10.15K
0x76a6...bbb80x76a6...bbb8voted for
9.87K
0x035e...17d30x035e...17d3voted for
9.68K
0x4dc9...865a0x4dc9...865avoted for
7.05K
0xf342...33290xf342...3329voted for
5.96K
0x1f9c...270e0x1f9c...270evoted for
5.39K
0x36f7...a5890x36f7...a589voted for
3.93K
0x711c...d0a10x711c...d0a1voted for
3.79K
0xe11d...a20b0xe11d...a20bvoted for
3.32K
0x179a...92850x179a...9285voted for
1.98K
0x703a...789b0x703a...789bvoted for
1.75K
0xb3e6...26d10xb3e6...26d1voted for
1.38K
0xb35f...b1e10xb35f...b1e1voted for
419
0xa729...de600xa729...de60voted for
394
0xbc15...e8e30xbc15...e8e3voted for
359
0x0253...d11a0x0253...d11avoted for
246
0x35df...3aed0x35df...3aedvoted for
156
0x780e...d23c0x780e...d23cvoted for
150
0x51c5...58a80x51c5...58a8voted for
103
0xc554...77590xc554...7759voted for
100
0x6ee0...17450x6ee0...1745voted for
31
0x3ddc...05b00x3ddc...05b0voted for
16
0x1729...b8790x1729...b879voted for
10
0x0151...c3b90x0151...c3b9voted for
2
0x0579...ca090x0579...ca09voted for
2
0x2f2f...f78a0x2f2f...f78avoted for
1
0xa8e1...f37c0xa8e1...f37cvoted for
1
0x3fb1...4c8a0x3fb1...4c8avoted for
1
0x4d32...bbfa0x4d32...bbfavoted for
1
0x6446...d1610x6446...d161voted for
0
0xd712...13660xd712...1366voted for
0
0x2cbd...2c430x2cbd...2c43voted for
0
0xe8ee...08770xe8ee...0877voted for
0
0x0057...15c80x0057...15c8voted for
0
0xed4c...95080xed4c...9508voted for
0
0x7f21...31e00x7f21...31e0voted for
0
0x21ff...c5a80x21ff...c5a8voted for
0
0x1523...080f0x1523...080fvoted for
0
0xee2a...58a70xee2a...58a7voted for
0
0xa6ac...2bf30xa6ac...2bf3voted for
0
0xacc9...0b280xacc9...0b28voted for
0
0xe6b8...452d0xe6b8...452dvoted for
0
0xc4cd...47bc0xc4cd...47bcvoted for
0
0x4d12...7d7c0x4d12...7d7cvoted for
0
0x38dc...472d0x38dc...472dvoted for
0
0x93e0...f6ee0x93e0...f6eevoted for
0
0xa0d0...604a0xa0d0...604avoted for
0
0xd248...32ae0xd248...32aevoted for
0
0x95d2...88f90x95d2...88f9voted for
0
0x7a04...17a80x7a04...17a8voted for
0
0x1475...6e150x1475...6e15voted for
0
0xbef8...99990xbef8...9999voted for
0
0xbac8...13b30xbac8...13b3abstained
0
0x3917...31e30x3917...31e3voted for
0
0x1c05...40940x1c05...4094voted for
0
0xd8de...ae410xd8de...ae41voted for
0
0x72b4...86580x72b4...8658voted for
0
Nice
0x9a75...a8c50x9a75...a8c5voted for
0
ENS DAO | [EP 6.40] [Executable] Update DNSSEC Algorithm 7