Home
EXECUTED
Ends Jul 8 at 7:47 AM UTC

[EP 5.12] Roles Modifier V2 Migration & Updates to Endowment Permissions


By
Skip to Votes

Abstract

This proposal aims to roll out an updated version of the Zodiac Roles Modifier module. The new version improves usability and transparency of treasury management operations. Upon approval, the Roles Modifier v2 module will be activated.

Furthermore, this proposal requests authorization from the DAO to revise the permissions policy. A notable change includes enabling swapping actions on CoW Swap while the other permissions primarily focus on eliminating obsolete actions and protocols, and refining parameters within the existing permissions.

Roles v2 Migration

Motivation

As previously stated, the Zodiac Roles Modifier facilitates karpatkey’s proxy management of the Endowment by ensuring that only pre-approved transactions, defined by the permissions policy voted on by the DAO, can be executed. In collaboration with karpatkey, the Gnosis Guild team has significantly upgraded the Zodiac Roles Modifier module and the Zodiac Roles app. These enhancements have resulted in a more powerful and robust on-chain permissions infrastructure with the following improvements:

  • Introduction of Allowances: Implementation of spending limits within permissions.
  • Enhanced Call Data Scoping Toolset: This toolset considerably broadens the range of functions that can have permissions set, increasing flexibility.
  • Advanced Logical Conditions: Allows for the creation of complex permissions structures to accommodate sophisticated operational needs.
  • Compatibility with DeFi Kit: This feature integrates with karpatkey’s permissions policy building module, facilitating the straightforward crafting of protocol actions.
  • Improved Visualisation and User Interface: the new Zodiac Roles app UI 1 not only displays permissions clearly but also provides a user-friendly interface to compare changes in each policy update, enhancing transparency and simplifying audits.

For more detailed information, please refer to the following resources:

Contract Audits

The Zodiac Roles Modifier v2 contract has been rigorously audited by G0 Group, the internal auditing team of Gnosis DAO, and by Omniscia. The detailed audit reports are available for review here 1.

Changes to the Permissions Policy

This proposal outlines the following modifications to the permissions policy:

  1. Token Arrays for Swapping:
    1. Considering the tokens involved in the existing permissions, we have updated the token arrays to ensure they can be seamlessly swapped across the various whitelisted protocols and aggregators.
    2. Token IN Allowlist: [CRV, DAI, USDT, BAL, AURA, CVX, ETHx, COMP, rETH, SWISE, wstETH, LDO, WETH, ankrETH, USDC, stETH].
    3. Token OUT Allowlist: [DAI, USDT, USDC, rETH, wstETH, WETH, stETH].
    4. The above arrays are to be utilised for swapping on CoW Swap, with equivalent lists replicated for Uniswap v3 and Balancer.
  2. Introduction of CoW Swap (diff 4): 5. Addition of a CoW Swap Order signer to enable gas-minimised and MEV-protected swaps. This includes an extensive set of aggregated exchange routes, improving the efficiency and effectiveness of required swaps. 6. Tokens will be swapped on CoW Swap according to the token IN/OUT allowlists mentioned above.
  3. Deprecations and Removals: 7. Uniswap v2 Swaps (diff 1): Removed due to insufficient liquidity in V2 pools. 8. Stakewise v2: Deprecated functions related to deposit (diff 1) and claim (diff 1) functions in light of the recent launch of Stakewise v3. Consequently, permitted actions related to Stakewise v2’s sETH2-ETH Uniswap pool are also removed (diff). 9. Compound v2 (diff): Discontinued all actions targeting v2 contracts and v2 cTokens (cUSDC and cDAI) due to the ongoing transition of the protocol to its v3. 10. Revocation of Existing/Obsolete Allowances: All existing and outdated allowances previously set by the Endowment are revoked (set to zero). The ability to call the corresponding approve functions is included in the newly proposed policy. Accordingly, the payload contains a bundle of transactions to revoke these allowances.
  4. Updates: 11. Uniswap v3 (diff 1and Balancer (diff): Adjusted to allow the mentioned token IN/OUT allowlists. 12. Curve Pools: Addition of stETH-ng (factory) pool (diff) and removal of cUSDC + cDAI pool (diff 1; Compound v2 tokens). 13. Curve ZAP Deposit Contract (diff): Introduced to allow depositing and staking of LP tokens in a single step. 14. Convex Staking (diff): Added the CVX/stETH Rewards contract. 15. Lido Withdrawals (diff): Enhanced to include new withdrawal methods using permits for both wstETH and stETH; methods include requestWithdrawalsWstETHWithPermit and requestWithdrawalsWithPermit. 16. Spark Rewards Claim (diff 1): Added functionality to claim wstETH rewards in Spark.

Audit Considerations

We highly value the community’s involvement in reviewing and providing feedback on this proposal. We encourage members with the necessary technical expertise to examine the content carefully (including this payload 1) and share their insights with us.

For effective testing of the permissions policy configuration, we have utilised a Testing Avatar Safe 1. This safe mirrors the current state of the permissions policy v4 1 granted by the Endowment to the Manager SAFE operated by karpatkey. The enhancements in the Zodiac Roles app interface now allow for a clear visualisation of all existing permissions, accessible here 2.

The updated interface also simplifies the process of identifying changes by displaying the current permissions policy on the left side and the newly proposed policy on the right side. To further aid in the adoption and understanding of these tools for audit purposes, we have detailed the proposed changes in version 5 documentation, following our standard Policy Update Request (PUR) format.

Additional considerations

Roles Modifier v1 and Enabling of v2

The existing Roles Modifier v1 module will remain active to ensure a smooth transition and prevent any unexpected disruptions in operational execution. Ownership of the deployed Roles Modifier v2 module 1, equipped with the new proposed permissions policy, has been transferred 1 to the Endowment’s Avatar Safe. These permissions are displayed here 4 and match those shown on the comparison interface here 1. The payload will only activate this module, marking the first phase of the migration process. A subsequent policy update proposal will seek to disable the v1 module.

Policy Visualisation in Terms of DeFi Kit Actions

The “show annotations” button, located at the top-right here 1, provides a visualisation of the proposed permissions policy expressed through the DeFi Kit Protocol Actions. This feature offers a more abstract and simplified description of the policy, enhancing understanding and accessibility.

Votes
Quorum progress: 137.59%
For votes: 666.38K
Against votes: 643
0x5bfc...83900x5bfc...8390abstained
239.15K
0x2b88...7d120x2b88...7d12abstained
138.12K
https://discuss.ens.domains/t/ep-5-12-roles-modifier-v2-migration-updates-to-endowment-permissions/19173/8?u=lefterisjp
0xb8c2...67d50xb8c2...67d5voted for
132.67K
0x8393...07800x8393...0780voted for
130.88K
0x9831...67440x9831...6744abstained
130.55K
0x76a6...bbb80x76a6...bbb8abstained
125.99K
I couldn't review all the call data. Therefore, I'm not comfortable voting "For."
0x809f...f68e0x809f...f68evoted for
106.93K
0xe391...b4060xe391...b406voted for
100K
0x54be...7ab60x54be...7ab6abstained
74.17K
0xd132...e9480xd132...e948voted for
47.58K
0x2d7d...b05e0x2d7d...b05evoted for
46.35K
0xbce3...776f0xbce3...776fvoted for
34.33K
0xd5d1...cf2c0xd5d1...cf2cvoted for
18.02K
0x7ae9...0c0b0x7ae9...0c0bvoted for
12.48K
0xe52c...d7260xe52c...d726voted for
8.93K
0x29a8...de700x29a8...de70voted for
6.4K
0x5346...42cf0x5346...42cfvoted for
6.3K
0x0291...1b630x0291...1b63voted for
5.57K
0xf342...33290xf342...3329voted for
3.6K
0xa786...77c60xa786...77c6voted for
2.44K
0x30c7...c7020x30c7...c702voted for
1.95K
0xac50...c0390xac50...c039abstained
1K
0x8b1f...feff0x8b1f...feffvoted for
698
0xd4a4...8b550xd4a4...8b55voted against
642
While the proposal seems to add valuable upgrades to the Roles Modifier and presents many benefits, it is quite complex. This complexity could affect transparency and make it harder for the proposal to be audited by the community, and may not ensure the long-term viability and usefulness for the ENS community as indicated in the DAO constitution's third article. The proposal needs to be more explicit how this complex upgrade directly leads to positive impacts in the ENS ecosystem or serves the ENS community to align with the delegate's preference.
0x4767...96ff0x4767...96ffvoted for
505
0x035e...17d30x035e...17d3abstained
348
0x0253...d11a0x0253...d11avoted for
246
0x0579...40480x0579...4048voted for
239
0x50b6...5a180x50b6...5a18abstained
173
0x168f...74000x168f...7400voted for
131
0x697d...04530x697d...0453voted for
36
0xc754...99050xc754...9905voted for
22
0x70df...18890x70df...1889voted for
16
0xc5af...e8d20xc5af...e8d2voted for
11
0x1a19...39c50x1a19...39c5abstained
11
0x2748...ac260x2748...ac26voted for
5
0x7334...4be50x7334...4be5voted for
3
0xc34a...68c20xc34a...68c2voted for
3
0xe099...d4e00xe099...d4e0voted for
2
0x7bf4...ddd00x7bf4...ddd0voted for
2
0xe7a2...dcbd0xe7a2...dcbdvoted for
2
0xd260...b1b60xd260...b1b6voted for
2
0x06c4...66a20x06c4...66a2voted for
2
0x9e4d...96360x9e4d...9636voted for
1
0xf61b...61040xf61b...6104voted for
1
0x875b...ba700x875b...ba70voted for
1
0xa8f5...e18f0xa8f5...e18fvoted for
1
0x8bb9...ccc20x8bb9...ccc2voted for
1
0xbfd2...5e050xbfd2...5e05voted for
1
0x5c8c...062d0x5c8c...062dvoted for
1
0x45d1...2e550x45d1...2e55voted for
1
0xf7f3...91f50xf7f3...91f5voted for
1
0xd83a...5fc50xd83a...5fc5voted for
1
0x1c05...40940x1c05...4094voted for
0
0x1016...d0830x1016...d083voted for
0
0x48b5...69500x48b5...6950voted for
0
0x3a1f...21dc0x3a1f...21dcabstained
0
0xb929...bee20xb929...bee2voted for
0
0xc04a...9a110xc04a...9a11voted against
0
0xc8f4...17580xc8f4...1758voted for
0
0xd3d4...af350xd3d4...af35voted for
0
0x134d...b65c0x134d...b65cvoted for
0
0xa4db...95150xa4db...9515voted for
0
0x3163...0cee0x3163...0ceevoted for
0
0x90a0...243b0x90a0...243bvoted for
0
0x1bae...f5ac0x1bae...f5acvoted for
0
0x56d8...d34d0x56d8...d34dvoted for
0
0xc405...ff560xc405...ff56voted for
0
0xb986...21750xb986...2175voted for
0
0x2221...bcd20x2221...bcd2voted for
0
0x406e...f9920x406e...f992voted for
0
0xc720...c12f0xc720...c12fvoted for
0
0xaf05...9f910xaf05...9f91voted for
0
0x2d84...7ac30x2d84...7ac3voted for
0
0xf88c...bdfd0xf88c...bdfdvoted for
0
0xf92e...3da50xf92e...3da5voted for
0
0xd8de...ae410xd8de...ae41voted for
0
0x8c23...7c730x8c23...7c73voted for
0
0x3f52...61a80x3f52...61a8voted for
0
0x88ac...93f40x88ac...93f4voted for
0
0x274d...73f40x274d...73f4voted for
0
0x4899...d7fb0x4899...d7fbvoted for
0
0x791f...289a0x791f...289avoted for
0
0x8567...1b500x8567...1b50voted for
0
0xb00c...76ee0xb00c...76eevoted for
0
0x4632...3d8b0x4632...3d8bvoted for
0
0x229c...e4c50x229c...e4c5voted for
0
0x8d66...9eba0x8d66...9ebaabstained
0
0x9002...c5050x9002...c505voted against
0
0xeb11...99fe0xeb11...99feabstained
0
0xd5e2...91c10xd5e2...91c1voted for
0
0x2dad...b67d0x2dad...b67dvoted against
0
The proposal is quite comprehensive and well thought out, however, it does not clearly indicate how it would directly contribute to increasing the DAO's treasury or profit in either the short or long term. As such, it does not align with the mandate to vote on proposals that have a clear path to generating Returns on Investment for the DAO.
0x3fbf...00370x3fbf...0037voted for
0
0x25e5...48730x25e5...4873voted for
0
0xf944...60490xf944...6049voted against
0
The proposal is vague and does not clearly demonstrate how the suggested improvements, facilitated by an updated Zodiac Roles Modifier, benefit the ENS protocol specifically. There are numerous points related to various protocols and systems, but none addressing the ENS protocol directly. Given my preference towards directing funds towards projects and initiatives that focus specifically on ENS protocol improvements, I cannot support this proposal in its current form.
0xff94...991a0xff94...991avoted for
0
0xf5e2...aa500xf5e2...aa50voted for
0